Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake build warning: cmake --help-policy CMP0148 #472

Open
dvtate opened this issue Jul 14, 2024 · 2 comments
Open

cmake build warning: cmake --help-policy CMP0148 #472

dvtate opened this issue Jul 14, 2024 · 2 comments

Comments

@dvtate
Copy link

dvtate commented Jul 14, 2024

cmake gives the following build warning:

CMake Warning (dev) at third_party/SQLiteCpp/CMakeLists.txt:390 (find_package):
  Policy CMP0148 is not set: The FindPythonInterp and FindPythonLibs modules
  are removed.  Run "cmake --help-policy CMP0148" for policy details.  Use
  the cmake_policy command to set the policy and suppress this warning.
@UnixY2K
Copy link
Contributor

UnixY2K commented Jul 23, 2024

this is due to: CMP0148
I think it could be replaced by FindPython3,

probably something like this should be enough to remove the warning and be backwards compatible:

if(CMAKE_VERSION VERSION_LESS "3.27") 
    #the code that uses findpython3
else()
    #the old code
endif()

I think that python was used in the cmake build for linting or running unit tests

@UnixY2K
Copy link
Contributor

UnixY2K commented Sep 15, 2024

#454 fixed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants