Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why wasn't BJ initially stored in folders #322

Open
jzy-chitong56 opened this issue Jun 5, 2024 · 11 comments
Open

Why wasn't BJ initially stored in folders #322

jzy-chitong56 opened this issue Jun 5, 2024 · 11 comments
Labels
enhancement New feature or request

Comments

@jzy-chitong56
Copy link
Contributor

I understand that the internet used to be poor, reducing files can shorten download time. But now it's completely unnecessary
Put all BJs into the corresponding version, eliminating version naming, which seems more convenient for installation

image

@SMUnlimited
Copy link
Owner

It used to be because we copied entire contents of the folder containing the ai scripts to the map mainly to support custom races, and as the blizzard.j is an optional file we would not want to auto include.

But we now add to map via the *.ai filter so it may now be fine to combine and it won't break anything.

@jzy-chitong56
Copy link
Contributor Author

You can also include VSai for further refinement, including the installer and mode selection

@SMUnlimited SMUnlimited added the enhancement New feature or request label Jun 6, 2024
@jzy-chitong56
Copy link
Contributor Author

try to support writing to the registry to achieve sideloading startup , like this

image

@jzy-chitong56
Copy link
Contributor Author

jzy-chitong56 commented Aug 29, 2024

BJ has a default language, and for ordinary players, they do not have the ability to modify files to set the default language. Therefore, for non English players, when using the official version - which is your version - they can only choose the language every time they enter the game.

If the BJ default language can be set on the installer, they can avoid the trouble of choosing the language every time

#390

@jzy-chitong56
Copy link
Contributor Author

Creating VS AI replicas will be a big project
All installation scripts (InstallToDir. pl) need to be refactored, and I am at a loss and hesitant

The simplest way is to create an installation script for VS AI mode
But there are already too many compiled and installed scripts, which are very unfriendly. The new installer is also too large in size, making it too cumbersome to download @paulo101977

@paulo101977
Copy link
Contributor

Creating VS AI replicas will be a big project All installation scripts (InstallToDir. pl) need to be refactored, and I am at a loss and hesitant

The simplest way is to create an installation script for VS AI mode But there are already too many compiled and installed scripts, which are very unfriendly. The new installer is also too large in size, making it too cumbersome to download @paulo101977

And the installer also uses the current scripts. It's just a way to make it easier for laypeople who don't know how to use such scripts.

An alternative would be to modify the installer in such a way as to perform such procedures using commands from the operating system itself. I also don't know if it's viable or complex.

@jzy-chitong56
Copy link
Contributor Author

Creating VS AI replicas will be a big project All installation scripts (InstallToDir. pl) need to be refactored, and I am at a loss and hesitant
The simplest way is to create an installation script for VS AI mode But there are already too many compiled and installed scripts, which are very unfriendly. The new installer is also too large in size, making it too cumbersome to download @paulo101977

And the installer also uses the current scripts. It's just a way to make it easier for laypeople who don't know how to use such scripts.

An alternative would be to modify the installer in such a way as to perform such procedures using commands from the operating system itself. I also don't know if it's viable or complex.

Actually, I just miss the size of the old installer, which was only a few M and easy to spread

@paulo101977
Copy link
Contributor

Creating VS AI replicas will be a big project All installation scripts (InstallToDir. pl) need to be refactored, and I am at a loss and hesitant
The simplest way is to create an installation script for VS AI mode But there are already too many compiled and installed scripts, which are very unfriendly. The new installer is also too large in size, making it too cumbersome to download @paulo101977

And the installer also uses the current scripts. It's just a way to make it easier for laypeople who don't know how to use such scripts.
An alternative would be to modify the installer in such a way as to perform such procedures using commands from the operating system itself. I also don't know if it's viable or complex.

Actually, I just miss the size of the old installer, which was only a few M and easy to spread

But the size of this current installer can be reduced to the extreme. This is done in the build process. If you optimize this process, the size of the installer decreases.

@jzy-chitong56
Copy link
Contributor Author

@SMUnlimited can you try

Creating VS AI replicas will be a big project All installation scripts (InstallToDir. pl) need to be refactored, and I am at a loss and hesitant
The simplest way is to create an installation script for VS AI mode But there are already too many compiled and installed scripts, which are very unfriendly. The new installer is also too large in size, making it too cumbersome to download @paulo101977

And the installer also uses the current scripts. It's just a way to make it easier for laypeople who don't know how to use such scripts.
An alternative would be to modify the installer in such a way as to perform such procedures using commands from the operating system itself. I also don't know if it's viable or complex.

Actually, I just miss the size of the old installer, which was only a few M and easy to spread

But the size of this current installer can be reduced to the extreme. This is done in the build process. If you optimize this process, the size of the installer decreases.

Could you please handle it? Thank you

@paulo101977
Copy link
Contributor

@SMUnlimited can you try

Creating VS AI replicas will be a big project All installation scripts (InstallToDir. pl) need to be refactored, and I am at a loss and hesitant
The simplest way is to create an installation script for VS AI mode But there are already too many compiled and installed scripts, which are very unfriendly. The new installer is also too large in size, making it too cumbersome to download @paulo101977

And the installer also uses the current scripts. It's just a way to make it easier for laypeople who don't know how to use such scripts.
An alternative would be to modify the installer in such a way as to perform such procedures using commands from the operating system itself. I also don't know if it's viable or complex.

Actually, I just miss the size of the old installer, which was only a few M and easy to spread

But the size of this current installer can be reduced to the extreme. This is done in the build process. If you optimize this process, the size of the installer decreases.

Could you please handle it? Thank you

I will try to find time, but I can't promise as I am involved in two postgraduate courses and studying artificial intelligence heavily here.

@paulo101977
Copy link
Contributor

@SMUnlimited can you try

Creating VS AI replicas will be a big project All installation scripts (InstallToDir. pl) need to be refactored, and I am at a loss and hesitant
The simplest way is to create an installation script for VS AI mode But there are already too many compiled and installed scripts, which are very unfriendly. The new installer is also too large in size, making it too cumbersome to download @paulo101977

And the installer also uses the current scripts. It's just a way to make it easier for laypeople who don't know how to use such scripts.
An alternative would be to modify the installer in such a way as to perform such procedures using commands from the operating system itself. I also don't know if it's viable or complex.

Actually, I just miss the size of the old installer, which was only a few M and easy to spread

But the size of this current installer can be reduced to the extreme. This is done in the build process. If you optimize this process, the size of the installer decreases.

Could you please handle it? Thank you

I think I found a possible solution here: https://medium.com/@paolo.c/optimizing-electron-js-apps-improve-security-and-reduce-package-size-81f33398de9a

But I still have to test it. Another point is the size of the bundle generated by Angular. I'll have to look into that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants