Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pure fixed-point math functions #1543

Open
4 of 11 tasks
heinezen opened this issue Sep 17, 2023 · 10 comments
Open
4 of 11 tasks

Pure fixed-point math functions #1543

heinezen opened this issue Sep 17, 2023 · 10 comments
Labels
good first issue Suitable for newcomers lang: c++ Done in C++ code nice new thing ☺ A new feature that was not there before

Comments

@heinezen
Copy link
Member

heinezen commented Sep 17, 2023

Required Skills: C++

Difficulty: Easy

We should add additional math operations to our fixed-point implementation, so that all calculations can be done purely deterministic.

The fpm library already has these operations and could be used as an inspiration.

Interesting for us:

  • sqrt
  • min
  • max
  • abs
  • hypot
  • atan2

Nice to have:

  • sin
  • cos
  • tan
  • pow
  • log

Further Reading

@heinezen heinezen added nice new thing ☺ A new feature that was not there before lang: c++ Done in C++ code good first issue Suitable for newcomers labels Sep 17, 2023
@heinezen heinezen added the hacktoberfest For newcomers from Hacktoberfest event label Sep 27, 2023
@heinezen
Copy link
Member Author

heinezen commented Oct 2, 2023

@mingjuu You can :)

I'll assign you right now and if you have any questions, feel free to ask here or in chat.

@heinezen heinezen changed the title Fixed point math functions Pure fixed-point math functions Nov 1, 2023
@heinezen heinezen removed the hacktoberfest For newcomers from Hacktoberfest event label Nov 4, 2023
@AyiStar

This comment was marked as outdated.

@heinezen

This comment was marked as outdated.

@AyiStar
Copy link
Contributor

AyiStar commented Nov 26, 2023

@heinezen Thank! I will touch you if I have any questions.

@adamresemius
Copy link

Hello,

Is there anything left to do here that I can contribute to?

@heinezen
Copy link
Member Author

@adamresemius Yes, the unticked boxes in the issue description is what's not implemented at the moment.

@Zain-Balkhi
Copy link

I think I know how to implement the other functions in fpm. I have pow already on mine.

@firednerve
Copy link

Hey, I'm a beginner and could try my hand at implementing sqrt (and possibly the others after) if it isn't being worked on right now

@heinezen
Copy link
Member Author

@firednerve You are welcome to go for it :)

@firednerve
Copy link

Thanks! I’ll ask if I have any questions.

@heinezen heinezen added the hacktoberfest For newcomers from Hacktoberfest event label Sep 20, 2024
@heinezen heinezen removed the hacktoberfest For newcomers from Hacktoberfest event label Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Suitable for newcomers lang: c++ Done in C++ code nice new thing ☺ A new feature that was not there before
Projects
Status: other
Development

No branches or pull requests

6 participants