-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabled style #790
Comments
This change looks fine to me. Let's just add an error message "this option is disabled" when pressing enter on a disable line. |
I'd also like it if you could alter the color for disabled choices (like grayed out). |
@verheyenkoen You could use |
@LitoMore I mean that I'd like it if you could tweak the color somehow for disabled choices (using colors "dim" or "blackBright/gray"), so it's more clear that they are not available. Currently they only have a textual prefix/suffix and default color, and the prefix is confusing as it could be interpreted as hierarchical: |
Would you be open to change the "disabled" appearance?
Things I think would improve the UX:
-
prefix, so that the options become aligned (as it currently is the disabled options actually stand out more than the active ones)✗
instead of❯
. Potentially make the line red instead of blue.(Disabled)
suffix - otherwise I have to parse my generated labelWould become:
I can offer to make the PR if you like those changes.
The text was updated successfully, but these errors were encountered: