Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validUntil updateable Metadata dependency breakage #568

Open
ckbaker10 opened this issue Dec 7, 2023 · 0 comments
Open

validUntil updateable Metadata dependency breakage #568

ckbaker10 opened this issue Dec 7, 2023 · 0 comments

Comments

@ckbaker10
Copy link

ckbaker10 commented Dec 7, 2023

Hello,

The validUntil field being mandatory in the generated metadata leads to the fact that metadata expiry must be monitored or automated.

Some IdPs don't provide that feature easily accessible which breaks the libraries usability

A real world example exists in Nextcloud, nextcloud/user_saml#36

I've added a parameter to disable the validUntil from being included, as well as matching tests

Pull request: #569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants