Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rt inference #239

Merged
merged 7 commits into from
Oct 12, 2023
Merged

Rt inference #239

merged 7 commits into from
Oct 12, 2023

Conversation

laraherriott
Copy link
Contributor

Summary

Notebook to illustrate inference of Rt on the New Zealand output files.

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #239 (414e712) into main (a7bf45d) will not change coverage.
The diff coverage is n/a.

❗ Current head 414e712 differs from pull request most recent head b853b79. Consider uploading reports for the commit b853b79 to get more accurate results

@@             Coverage Diff             @@
##              main      #239     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          105        47     -58     
  Lines         3380      1122   -2258     
===========================================
- Hits          3380      1122   -2258     

see 58 files with indirect coverage changes

Copy link
Contributor

@rccreswell rccreswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @laraherriott , Here are a few minor suggestions before merging this in

python_examples/R0_inference/learn_R.ipynb Outdated Show resolved Hide resolved
python_examples/R0_inference/learn_R.ipynb Outdated Show resolved Hide resolved
python_examples/R0_inference/learn_R.ipynb Outdated Show resolved Hide resolved
python_examples/R0_inference/learn_R.ipynb Outdated Show resolved Hide resolved
python_examples/R0_inference/learn_R.ipynb Show resolved Hide resolved
python_examples/R0_inference/learn_R.ipynb Outdated Show resolved Hide resolved
python_examples/R0_inference/learn_R.ipynb Outdated Show resolved Hide resolved
Copy link
Contributor

@I-Bouros I-Bouros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Richard's suggestions. Here are a couple of things I would also suggest you delete / change in addition.

python_examples/R0_inference/learn_R.ipynb Outdated Show resolved Hide resolved
python_examples/R0_inference/learn_R.ipynb Outdated Show resolved Hide resolved
python_examples/R0_inference/learn_R.ipynb Outdated Show resolved Hide resolved
python_examples/R0_inference/learn_R.ipynb Outdated Show resolved Hide resolved
Copy link
Contributor

@KCGallagher KCGallagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this, and the more standard $\tau = 7 days$

@laraherriott
Copy link
Contributor Author

Add Rt inference notebook

@laraherriott laraherriott merged commit 0bea1b8 into main Oct 12, 2023
15 checks passed
@laraherriott laraherriott deleted the rt-inference branch October 12, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants