Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(question) NotEnoughSpace error writing MIDI to port and 'harhar' error message #214

Open
Uma410 opened this issue Oct 4, 2024 · 3 comments

Comments

@Uma410
Copy link

Uma410 commented Oct 4, 2024

When writing a MIDI event (specifically an AllNotesOff event) to a MidiWriter I got the error NotEnoughSpace and the error message 'harhar'.
what???

what's actually going on and how do I fix this??
please tell me what information you need and maybe make the error message more useful?

@Uma410
Copy link
Author

Uma410 commented Oct 4, 2024

the only occurrence of the string 'harhar' is in
/src/client/callback.rs btw
code search

@Uma410 Uma410 changed the title NotEnoughSpace error writing MIDI to port and 'harhar' error message (question) NotEnoughSpace error writing MIDI to port and 'harhar' error message Oct 7, 2024
@Uma410
Copy link
Author

Uma410 commented Oct 7, 2024

I solved the problem, though I'm not sure why it works like this. the time field of the RawMidi has to be 0.

Can someone reply w/ an explanation so I can understand how this works a bit better?

@wmedrano
Copy link
Member

wmedrano commented Oct 9, 2024

We can probably improve the error message though. Maybe one of:

  • Return a custom error that explains all the prerequisites.
  • Possibly check (if little to no performance penalty) some of the prerequisites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants