From b853fe9b7f142df4cec2a191601be9f82be1c6fe Mon Sep 17 00:00:00 2001
From: Yaping Wang <49168260+ypwang19@users.noreply.github.com>
Date: Fri, 6 Sep 2024 17:32:14 -0400
Subject: [PATCH] Turn on OMA diagnostics after JEDI minimization (#1274)

---
 parm/aero/variational/3dvar_fgat_gfs_aero.yaml.j2 | 2 ++
 parm/aero/variational/3dvar_gfs_aero.yaml.j2      | 2 ++
 parm/atm/jcb-base.yaml.j2                         | 1 +
 parm/snow/jcb-base.yaml.j2                        | 2 +-
 parm/soca/marine-jcb-base.yaml                    | 1 +
 parm/soca/variational/3dvarfgat.yaml              | 2 ++
 test/atm/global-workflow/3dvar.ref                | 4 ++++
 7 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/parm/aero/variational/3dvar_fgat_gfs_aero.yaml.j2 b/parm/aero/variational/3dvar_fgat_gfs_aero.yaml.j2
index 95d27872c..751cbdf53 100644
--- a/parm/aero/variational/3dvar_fgat_gfs_aero.yaml.j2
+++ b/parm/aero/variational/3dvar_fgat_gfs_aero.yaml.j2
@@ -96,6 +96,8 @@ variational:
 final:
   diagnostics:
     departures: anlmob
+  prints:
+    frequency: PT3H
   increment:
     geometry:
       fms initialization:
diff --git a/parm/aero/variational/3dvar_gfs_aero.yaml.j2 b/parm/aero/variational/3dvar_gfs_aero.yaml.j2
index 47e005960..905d991e3 100644
--- a/parm/aero/variational/3dvar_gfs_aero.yaml.j2
+++ b/parm/aero/variational/3dvar_gfs_aero.yaml.j2
@@ -87,6 +87,8 @@ variational:
 final:
   diagnostics:
     departures: anlmob
+  prints:
+    frequency: PT3H
   increment:
     geometry:
       fms initialization:
diff --git a/parm/atm/jcb-base.yaml.j2 b/parm/atm/jcb-base.yaml.j2
index ee2caa3ae..6387fffbb 100644
--- a/parm/atm/jcb-base.yaml.j2
+++ b/parm/atm/jcb-base.yaml.j2
@@ -23,6 +23,7 @@ window_length: "{{ ATM_WINDOW_LENGTH }}"
 bound_to_include: begin
 minimizer: DRPCG
 final_diagnostics_departures: anlmob
+final_prints_frequency: PT3H
 number_of_outer_loops: 2
 analysis_variables: [ua,va,t,ps,sphum,ice_wat,liq_wat,o3mr]
 
diff --git a/parm/snow/jcb-base.yaml.j2 b/parm/snow/jcb-base.yaml.j2
index 8928d59e4..672b1bf8f 100644
--- a/parm/snow/jcb-base.yaml.j2
+++ b/parm/snow/jcb-base.yaml.j2
@@ -40,7 +40,7 @@ snow_increment_time_fv3: "{{ bkg_time_fv3 }}"
 analysis_variables: [ua,va,t,ps,sphum,ice_wat,liq_wat,o3mr]
 minimizer: DRPCG
 final_diagnostics_departures: anlmob
-
+final_prints_frequency: PT3H
 cost_type: 3D-Var
 number_of_outer_loops: 2
 
diff --git a/parm/soca/marine-jcb-base.yaml b/parm/soca/marine-jcb-base.yaml
index b7cec2422..fd14f0dbb 100644
--- a/parm/soca/marine-jcb-base.yaml
+++ b/parm/soca/marine-jcb-base.yaml
@@ -22,6 +22,7 @@ window_length: '{{ATM_WINDOW_LENGTH}}'
 bound_to_include: begin
 minimizer: RPCG
 final_diagnostics_departures: oman
+final_prints_frequency: PT3H
 number_of_outer_loops: 1
 analysis_variables: [cicen, hicen, hsnon, socn, tocn, uocn, vocn, ssh]
 
diff --git a/parm/soca/variational/3dvarfgat.yaml b/parm/soca/variational/3dvarfgat.yaml
index 344962f21..75af98617 100644
--- a/parm/soca/variational/3dvarfgat.yaml
+++ b/parm/soca/variational/3dvarfgat.yaml
@@ -51,6 +51,8 @@ output:
 final:
   diagnostics:
     departures: oman
+  prints:
+    frequency: PT3H
   increment:
     output:
       state component:
diff --git a/test/atm/global-workflow/3dvar.ref b/test/atm/global-workflow/3dvar.ref
index e84134433..33f4f60f6 100644
--- a/test/atm/global-workflow/3dvar.ref
+++ b/test/atm/global-workflow/3dvar.ref
@@ -88,3 +88,7 @@ sensorScanAngle_order_2:  Min= -5.1097259522434877,  Max= 2.8632600312042698,  N
 ---------------------------------------------------------------
 
 
+CostJb   : Nonlinear Jb = 0.0000033199535370
+CostJo   : Nonlinear Jo(AMSUA N19) = 39476.8510817764617968, nobs = 73667, Jo/n = 0.5358824315063252, err = 6.2697697603632934
+CostJo   : Nonlinear Jo(sondes) = 10639.2476170353256748, nobs = 4255, Jo/n = 2.5004107208073623, err = 10.9811231401273197
+CostFunction: Nonlinear J = 50116.0987021317414474