Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes are not reflected locally #429

Open
timalsinab opened this issue Nov 16, 2023 · 9 comments · May be fixed by #444
Open

Changes are not reflected locally #429

timalsinab opened this issue Nov 16, 2023 · 9 comments · May be fixed by #444
Assignees

Comments

@timalsinab
Copy link
Contributor

What is your username
@timalsinab @solijonovam

Describe the bug
When working on a front-end issue, making changes locally is not reflected. In order for changes to be reflected, we need to rebuild and reload the containers again and again even for small changes. Documentation could be enhanced with clear instructions on how to test changes locally.

@bnmnetp
Copy link
Member

bnmnetp commented Nov 17, 2023

Please see https://runestone-monorepo.readthedocs.io/en/latest/server_feature.html

If you think more needs to be said let me know. If that clarifies things then we can close.

@bnmnetp bnmnetp self-assigned this Nov 17, 2023
@timalsinab
Copy link
Contributor Author

Our classmates found that the instructions were effective to rebuild and to see the changes.
If included in the documentation, It might be helpful for new developers.

1. run pip install rich  in rs folder
2. Run ./build.py --one runestone --restart
3. Wait for runestone to build
4. Run docker compose down
5. Run docker compose up

@bnmnetp
Copy link
Member

bnmnetp commented Dec 4, 2023

You do not need to run pip install rich, if you activate the virtual environment with poetry shell from the rs folder.

Steps 4 and 5 are redundant. The --restart flag tells the build script do do just that.

@timalsinab
Copy link
Contributor Author

to clarify build instructions, would you like us to add step 2; we can also mention that you don't need to run pip install rich if you have a virtual environment activated. We can add these steps in the https://runestone-monorepo.readthedocs.io/en/latest/building_servers.html#building-and-running-the-servers. These steps were recommended to us by a classmate who was successfully able to build after struggling to do so for a while.

@bnmnetp
Copy link
Member

bnmnetp commented Dec 5, 2023

Step 5 on the page you reference says to run poetry shell. It also has quite a few instructions on starting and stopping servers.

Maybe the clarifications should be to this page? https://runestone-monorepo.readthedocs.io/en/latest/server_feature.html

Restating the process there of:

  1. make sure you run poetry shell
  2. run ./build.py --one XXXX --restart
    To work on features in a single server.

@solijonovam
Copy link
Contributor

Step 5 on the page you reference says to run poetry shell. It also has quite a few instructions on starting and stopping servers.

Maybe the clarifications should be to this page? https://runestone-monorepo.readthedocs.io/en/latest/server_feature.html

Restating the process there of:

  1. make sure you run poetry shell
  2. run ./build.py --one XXXX --restart
    To work on features in a single server.

Does XXXX stand for the book?

@bnmnetp
Copy link
Member

bnmnetp commented Dec 5, 2023

No, it stands for the service you are rebuilding and restarting.

@bnmnetp
Copy link
Member

bnmnetp commented Dec 5, 2023

Most command line commands give you helpful information if you run with the --help flag.

./build.py --help                                                                                            ─╯
Checking your environment
Usage: build.py [--verbose] [--help] [--all] [--push]
        --all build all containers, including author and worker
        --push push all containers to a container registry
        --one <service> build just one container, e.g. --one author
        --restart restart the container(s) after building

        If something in the build does not work or you have questions about setup or environment
        variables or installation, please check out our developer documentation.
        https://runestone-monorepo.readthedocs.io/en/latest/developing.html

@timalsinab
Copy link
Contributor Author

Thank you for replying. We will add the clarification to the https://runestone-monorepo.readthedocs.io/en/latest/server_feature.html. Really appreciate your help.

@timalsinab timalsinab linked a pull request Dec 7, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants