Skip to content
This repository has been archived by the owner on Sep 29, 2020. It is now read-only.

[Insight] Source code should not contain TODO comments - in recipes/php.rb, line 47 #86

Open
Rud5G opened this issue Mar 2, 2016 · 0 comments

Comments

@Rud5G
Copy link
Owner

Rud5G commented Mar 2, 2016

in recipes/php.rb, line 47

TODO comments are left in the code when a feature (or a bug) isn't completely developed (or fixed). You should complete the implementation and remove the comment.

# Chef::Node.send(:include, MysqlCookbook::Helpers)
# Chef::Resource::Mysql.send(:include, MysqlCookbook::Helpers)
# thesocketfile = socket_file
# Chef::Log.info("database helper: #{thesocketfile}")

# todo: replace with MysqlCookbook::Helpers socket_file
socket_file = "/run/mysql-default/mysqld.sock"

append_if_no_line 'set-php-apache2-mysql.default_socket' do
  path File.join(File.dirname(node['php']['conf_dir']), 'apache2', 'php.ini')
  line 'mysql.default_socket = ' + socket_file

Posted from SensioLabsInsight

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant