Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quote markdown #676

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Fix quote markdown #676

wants to merge 6 commits into from

Conversation

devanshkansagra
Copy link
Contributor

@devanshkansagra devanshkansagra commented Dec 1, 2024 •
edited
Loading

Fixed the quote markdown issue

Acceptance Criteria fulfillment

Now if you enter the message like this it won't create any issue

> I will not use abbrev.
>
> I will not use abbrev.
>
> I will not use abbrev.

Fixes #675

Video/Screenshots

image

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-676 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@Spiral-Memory
Copy link
Collaborator

Hi @devanshkansagra
I didn't really understand the issue, can you take some to explain it once.

@devanshkansagra
Copy link
Contributor Author

check this issue https://github.com/RocketChat/Rocket.Chat/issues/33493

Spiral-Memory
Spiral-Memory approved these changes Dec 15, 2024
View reviewed changes
Copy link
Collaborator

@Spiral-Memory Spiral-Memory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to test

@devanshkansagra
Copy link
Contributor Author

Not this one, the multiple quoting one and recursive quoting one

@devanshkansagra
Copy link
Contributor Author

#641

@Spiral-Memory
Copy link
Collaborator

Hi @devanshkansagra,

Blockquotes are typically used to highlight important notes or text. It would be better if you add a line as well. Additionally, blockquotes should support nesting.

Here’s an example for you. This will be rendered properly by GitHub:

> Hello  
> This is a blockquote.  
>> This is a nested blockquote.  

Hii

Hello
This is a blockquote.

This is a nested blockquote.

Hi

@devanshkansagra
Copy link
Contributor Author

Okay, will work on this highlighting and nesting the quotes

@devanshkansagra
Copy link
Contributor Author

devanshkansagra commented Dec 15, 2024 •
edited
Loading

Hey, can we implement this highlight thing by implementing a button in chatinput toolbar and on highlighting...users will able to highlight the thing they want to, if yes then I will add this addition in this pr

@Spiral-Memory
Copy link
Collaborator

Hey, can we implement this highlight thing by implementing a button in chatinput toolbar and on highlighting...users will able to highlight the thing they want to, if yes then I will add this addition in this pr

Not needed @devanshkansagra

@devanshkansagra
Copy link
Contributor Author

okk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spiral-Memory Spiral-Memory Spiral-Memory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: BlockQuote Markdown is not rendering properly
2 participants
@devanshkansagra @Spiral-Memory