-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webots_ros uses incorrect path for launching webots on Mac #453
Comments
The relevant code is https://github.com/cyberbotics/webots_ros/blob/a4c93300e1528ac4f8fbf5cb7c3ecee63ff69784/scripts/webots_launcher.py#L64-L67 . Did you already set Note that it is a bit of an hack, but to test you can also modify the |
Not sure if it is the cleanest possible solution, a possible trick is to remove the |
I have
I had tried just building the webots package, but was having all sorts of issues, but I think I just messed up my environment so I reset all my environments and started again, and now it seems to be building / running successfully with the patch. There's another similar bug related to paths, so I am going to try to patch that too and get them in a PR. |
Thanks! Can you also open an issue upstream at https://github.com/cyberbotics/webots_ros ? From what I understand, any solution would require either hardcoding the path or adding/changing the meaning of the env variable on macOS, and if upstream agrees on that, it would simplify future maintenance. |
I've raised the issue on the webots_ros repo, so hopefully they can provide some advice. If they don't come back in a day or two, I'll just raise the PR as in its current state as I have it at least working somewhat |
Nothing back from webots yet so have just created a PR for the original patch for now - #455 Not sure how to link it myself, I'm not sure I have sufficient privileges to do so |
Solution to issue cannot be found in the documentation.
Issue
In the launch script for Webots, I believe that the path used to launch the program points to the location of the executable on linux. This needs to be patched to point to
/Applications/Webots.app
I tried to patch this locally however had some issues getting the patch to build correctly. I now cannot seem to build the package locally as it is skipped in the vinca file due to existing on the robostack-staging channel.
If I can get some advice on how to do the build locally, I am pretty sure that I can fix this.
Installed packages
Environment info
The text was updated successfully, but these errors were encountered: