-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROS_IP set by default upon sourcing in Windows #430
Comments
It looks like this file
That file on linux is pretty much blank. Seems like you would have to set the ROS_HOSTNAME environment variable before activating the conda environment, and it would work how I expect. |
So this is a weird hack to avoid strange performance issues, the PR that added the change is here Following the chain all the way to |
Hi @gftabor, thanks for reporting this! Are you happy to open a PR that removes the undesired behaviour in ros_comm? Happy to review + merge. |
I made a PR directly to ros_comm, seems like the weird behavior is all upstream. If they don't accept the PR there then we can look at making patch here in robostack |
xref: ros/ros_comm#2364 |
This would be fixed by a rebuild as ros/ros_comm#2364 was merged |
Solution to issue cannot be found in the documentation.
Issue
Robostack on windows automatically sets ROS_IP to local host (incorrect behavior) but not doing it on linux (correct behavior).
The problem is I was setting ROS_HOSTNAME but ros was choosing to listen to IP over HOSTNAME when both were set. On linux neither ROS_IP nor ROS_HOSTNAME environment variables are set by default, so its easier to overwrite
Results of
printenv | grep ROS
on Linux
On Windows
Interestingly
C:\Users\tabor\anaconda3\envs\foundations\etc\conda\activate.d\ros-noetic-catkin_activate.bat
doesn't mention ROS_MASTER_URI or ROS_IP but both are set.Installed packages
Environment info
The text was updated successfully, but these errors were encountered: