Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong default deviceSize in the constructor of I2C_eeprom #79

Closed
ekinohito opened this issue Nov 24, 2024 · 4 comments · Fixed by #80
Closed

Wrong default deviceSize in the constructor of I2C_eeprom #79

ekinohito opened this issue Nov 24, 2024 · 4 comments · Fixed by #80
Assignees
@RobTillaart
Labels
bug Something isn't working

Comments

@ekinohito
Copy link
Contributor

I2C_EEPROM/I2C_eeprom.cpp

Line 39 in 43f4886

I2C_eeprom(deviceAddress, I2C_PAGESIZE_24LC256, wire)

Default deviceSize in this constructor is I2C_PAGESIZE_24LC256 when it should be I2C_DEVICESIZE_24LC256
ekinohito added a commit to ekinohito/I2C_EEPROM that referenced this issue Nov 24, 2024
@ekinohito
Fix RobTillaart#79
5e40479
@RobTillaart RobTillaart self-assigned this Nov 24, 2024
@RobTillaart RobTillaart added the bug Something isn't working label Nov 24, 2024
@RobTillaart
Copy link
Owner

Sounds like a bug, will look into it coming week.

@RobTillaart
Copy link
Owner

Bug confirmed.

@RobTillaart RobTillaart linked a pull request Nov 25, 2024 that will close this issue
Fix RobTillaart/I2C_EEPROM#79 #80
Merged
@RobTillaart
Copy link
Owner

@ekinohito

Created a develop branch / PR to update the version to 1.9.2

Thanks again for reporting this issue, appreciated

@RobTillaart
Copy link
Owner

@ekinohito
FYI, released 1.9.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobTillaart RobTillaart

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix RobTillaart/I2C_EEPROM#79 ekinohito/I2C_EEPROM
2 participants
@RobTillaart @ekinohito