Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promoting docblock type of a property to actual type #742

Open
weirdan opened this issue Mar 15, 2023 · 1 comment
Open

Promoting docblock type of a property to actual type #742

weirdan opened this issue Mar 15, 2023 · 1 comment

Comments

@weirdan
Copy link
Contributor

weirdan commented Mar 15, 2023

See https://github.com/vimeo/psalm/pull/9517/files

Should this be considered a BC break? If we trust the @internal annotation, why shouldn't we trust @var as well?
@weirdan weirdan mentioned this issue Mar 15, 2023
Merged
@Ocramius
Copy link
Member

The problem here is that docblock type information is not really compared to native type information at all 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weirdan @Ocramius