Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not crash when Fqsen parsing fails #134

Closed
4 tasks done
Ocramius opened this issue Jun 10, 2019 · 1 comment · Fixed by #142
Closed
4 tasks done

Do not crash when Fqsen parsing fails #134

Ocramius opened this issue Jun 10, 2019 · 1 comment · Fixed by #142
Assignees
Labels

Comments

@Ocramius
Copy link
Member

Ocramius commented Jun 10, 2019

As discussed with @sebastianbergmann (sebastianbergmann/phpunit#3718), type annotations like array<foo, bar> and other more complex definitions currently lead to the phpdocumentor tooling to throw exceptions.

While it would be good to support these in full, this currently prevents picking up this tool at all in downstream consumers.

The suggestion is therefore to

  1. Suppress Fqsen parsing errors
  2. Improve upstream Fqsen parsing tooling not needed: see Migrate to better type inference tooling to detect BC breaks in types #143
  3. Adapt covariance/contravariance checks to support more complex types moved to Migrate to better type inference tooling to detect BC breaks in types #143
  4. Extract covariance/contravariance checks to a new namespace/library that only does that, making it easier to upgrade its capabilities moved to Migrate to better type inference tooling to detect BC breaks in types #143
@Ocramius
Copy link
Member Author

Incomplete tasks deferred to #143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant