Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XCFramework shouldn't be distributed with Swift standard libraries #13

Open
username0x0a opened this issue May 11, 2022 · 8 comments
Open
Assignees

Comments

@username0x0a
Copy link

Analysing the 1.3.0 update, I've noticed a great increase in the xcframework bundle size. Looking closely, the framework now carries Swift standard libraries. These should be only bundled to the target app if needed (and deploying to iOS 12.3 and earlier OS versions) or not at all as for later deployment targets, Swift 5 ABI compatibility handles it.

Please rebuild the xcframework without the Swift standard libraries bundled. 👍

@username0x0a
Copy link
Author

Cc @mooseriskified @dormini

@mooseriskified mooseriskified self-assigned this May 25, 2022
@mooseriskified
Copy link
Contributor

@username0x0a fixed. We are changing the deployment target as well as additional fixes and then releasing it. We are aiming for a Friday (May/27) release

@username0x0a
Copy link
Author

Thanks for info 👍 I'll be floating around to give a feedback, shall you need some before the release. 👌

@adellibovi
Copy link

adellibovi commented May 30, 2022

Hello @mooseriskified ,
We noticed as well that the .xcframework does support bitcode. :/ Any update regarding the May/27 release?

@mooseriskified
Copy link
Contributor

mooseriskified commented May 31, 2022

@adellibovi We moved it to Tuesday ( tomorrow ) as we identified a simple bug in the pre-release. Ill ping you once we release it

@adellibovi
Copy link

Will it fix also the issue mentioned about with Bitcode generation @mooseriskified ? #15

@mooseriskified
Copy link
Contributor

@adellibovi yes that was fixed

@mooseriskified
Copy link
Contributor

@username0x0a we fixed the issue, let me know how it looks on your end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants