Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File names with special characters such as "!" make the program crash. #28

Open
KcrPL opened this issue Apr 23, 2020 · 2 comments · May be fixed by #38
Open

File names with special characters such as "!" make the program crash. #28

KcrPL opened this issue Apr 23, 2020 · 2 comments · May be fixed by #38
Assignees
@KcrPL
Labels
bug Windows

Comments

@KcrPL
Copy link
Collaborator

KcrPL commented Apr 23, 2020

When trying to patch a file with some special characters, the program crashes.

It might be impossible to fix because of the nature of batch. I'll investigate.
@KcrPL KcrPL self-assigned this Apr 23, 2020
@KcrPL
Copy link
Collaborator Author

KcrPL commented Apr 23, 2020

File names with special characters such as "!" make the program crash.

@TheShadowEevee TheShadowEevee linked a pull request Mar 13, 2021 that will close this issue
Open
@TheShadowEevee
Copy link
Collaborator

I created a PR (#38) that I believe fixes this, although I requested it be tested first. I requested a review from you as the creator of this issue, and the main person behind the windows patcher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KcrPL KcrPL

Labels
bug Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix exclamation points in file names breaking the patcher
2 participants
@KcrPL @TheShadowEevee