Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output operators access non-existent members #486

Open
manfred-ernst opened this issue May 8, 2024 · 1 comment
Open

Output operators access non-existent members #486

manfred-ernst opened this issue May 8, 2024 · 1 comment

Comments

@manfred-ernst
Copy link

operator<<(embree_ostream cout, const PointMi& line) in kernels/geometry/pointi.h accesses the non-existent member line.v0.
operator<<(embree_ostream cout, const QuadraticBezierCurve& a) in kernels/subdiv/bezier_curve.h accesses the non-existent member a.u.
@dopitz
Copy link
Collaborator

dopitz commented May 13, 2024

Hi, just fixed this. The fix should be available in the next release.

Thanks!

freibold pushed a commit that referenced this issue May 21, 2024
@dopitz @freibold
fix output operator, issue #486
cda4cf1
freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this issue Oct 5, 2024
@DimitryAndric
graphics/embree: fix build with clang 19
7bf7810 
Clang 19 has become more strict about errors in member functions, which
results in errors building graphics/embree:

  /wrkdirs/usr/ports/graphics/embree/work/embree-3.13.5/kernels/geometry/../common/../subdiv/bezier_curve.h:138:56: error: no member named 'u' in 'QuadraticBezierCurve<V>'
    138 |         return cout << "QuadraticBezierCurve ( (" << a.u.lower << ", " << a.u.upper << "), " << a.v0 << ", " << a.v1 << ", " << a.v2 << ")";
        |                                                      ~ ^
  /wrkdirs/usr/ports/graphics/embree/work/embree-3.13.5/kernels/geometry/../common/../subdiv/bezier_curve.h:138:77: error: no member named 'u' in 'QuadraticBezierCurve<V>'
    138 |         return cout << "QuadraticBezierCurve ( (" << a.u.lower << ", " << a.u.upper << "), " << a.v0 << ", " << a.v1 << ", " << a.v2 << ")";
        |                                                                           ~ ^

Upstream fixed this for RenderKit/embree#486
in RenderKit/embree@cda4cf191, so add a
PATCHFILES entry for it.

PR:		281868
Approved by:	danfe (maintainer)
MFH:		2024Q3
freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this issue Oct 5, 2024
@DimitryAndric
graphics/embree: fix build with clang 19
787b4f9 
Clang 19 has become more strict about errors in member functions, which
results in errors building graphics/embree:

  /wrkdirs/usr/ports/graphics/embree/work/embree-3.13.5/kernels/geometry/../common/../subdiv/bezier_curve.h:138:56: error: no member named 'u' in 'QuadraticBezierCurve<V>'
    138 |         return cout << "QuadraticBezierCurve ( (" << a.u.lower << ", " << a.u.upper << "), " << a.v0 << ", " << a.v1 << ", " << a.v2 << ")";
        |                                                      ~ ^
  /wrkdirs/usr/ports/graphics/embree/work/embree-3.13.5/kernels/geometry/../common/../subdiv/bezier_curve.h:138:77: error: no member named 'u' in 'QuadraticBezierCurve<V>'
    138 |         return cout << "QuadraticBezierCurve ( (" << a.u.lower << ", " << a.u.upper << "), " << a.v0 << ", " << a.v1 << ", " << a.v2 << ")";
        |                                                                           ~ ^

Upstream fixed this for RenderKit/embree#486
in RenderKit/embree@cda4cf191, so add a
PATCHFILES entry for it.

PR:		281868
Approved by:	danfe (maintainer)
MFH:		2024Q3

(cherry picked from commit 7bf7810)
@Innovgame Innovgame mentioned this issue Nov 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dopitz @manfred-ernst