-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update source data? #45
Comments
Which differences do you see? The basic source is indeed from Wikipedia. I did a cross check and there seems to be a couple of differences and see the following points:
Going to do some checks on these and change Wikipedia and NodaMoney. |
I'm worried about the EnglishName. I didn't expect there to be so many differences. For example: USD I'm tempted to believe that currency-iso.org is closer to the ISO standard than Wikipedia but hell who knows... |
It's a bit unfortunate that I wouldn't mind if |
…of El Salvador between 1892 and 2001. Apparently it is never been officially removed after amendment 115.) Re-added Zimbabwe Dollar (ZWL) because it's on the ISO list (but is not used since 2009) removed USS (998) because it's removed from the list of ISO #45
The Unicode CLDR is a frequently-recommended source for such information. It is used by many "big name" companies, is well maintained and importantly also includes the information necessary for culture-dependent formatting of currency amounts (e.g. if I'm formatting USD in Sweden I'd expect to see "USD 123,45" rather than "$123.45" which is what I'd see if I were in the US). Client-side libraries like Globalize are built on the CLDR data and offer these more general formatting options. On the server side, there doesn't really seem to be anything comparable for .NET. In my case I'm looking for a way to format currencies on the server side (e.g. for sending notification emails with a price in them) using the same CLDR source data as I use on the client. Anyway, I just thought I'd share my opinion, although I imagine it would represent a considerable amount of work to change things to use the CLDR. As a side note, I found what appears to be some more out-of-date info in this project w.r.t. the CLDR at least: RSD no longer has fractional units, neither does COP. |
What is the source of the data in InitializeIsoCurrencies? Is it taken from Wikipedia?(https://github.com/remyvd/NodaMoney/blob/master/src/NodaMoney/CurrencyRegistry.cs#L135)
I'm asking because I use files from currency-iso.org in my application. They seem to be more up-to-date and complete than what NodaMoney provides: http://www.currency-iso.org/en/home/tables/table-a1.html
The text was updated successfully, but these errors were encountered: