Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: duplicate tag names should throw error #1732

Open
joriverm opened this issue Sep 13, 2024 · 2 comments
Open

feat: duplicate tag names should throw error #1732

joriverm opened this issue Sep 13, 2024 · 2 comments

Comments

@joriverm
Copy link

joriverm commented Sep 13, 2024

Is your feature request related to a problem? Please describe.
a openapi spec file that has 2 tags with the same name doesn't raise an error nor warning about it.

Describe the solution you'd like
i would expect the tool to at least throw a warning about the tag being duplicate. the swagger editor ( https://editor.swagger.io/ ) does complain about it and considers it an error

Describe alternatives you've considered
N/A, we currently have the tool running on a cron and we will see when it is added :)

Additional context
used json to test : petstore.json
used command : redocly lint petstore.json --lint-config=error --format=json
current log : log.txt

@joriverm joriverm added the Type: Bug Something isn't working label Sep 13, 2024
@tatomyr
Copy link
Contributor

tatomyr commented Sep 13, 2024

This isn't a bug, but rather a feature request. We need to add a rule to check for the uniqueness of tag names. Anyway, thanks for creating the issue!

@tatomyr tatomyr added Type: Enhancement p3 good first issue Good for newcomers and removed Type: Bug Something isn't working labels Sep 13, 2024
@joriverm
Copy link
Author

my mistake, i considered it a bug as it is apparently in the specs, but fair enough!
if any testing or info is needed let me know!

@joriverm joriverm changed the title duplicate tag names does not throw an error feat: duplicate tag names should throw error Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants