Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report generation - include screenshot even if website data cannot be gathered #671

Open
Relkci opened this issue Jun 14, 2024 · 0 comments
Labels
bug python Python codebase

Comments

@Relkci
Copy link
Collaborator

Relkci commented Jun 14, 2024

OS Used - ALL Information (architecture, linux flavor, etc.)

Pastebin link to error you are encountering

Expected behavior (vs. what you encountered)

A screenshot should always be included in the report if it exists, even if urllib was unable to capture data.

If a screenshot is created for a website (selenium), but EyeWitness failed to gather information about the website (urllib), the screenshot should be included in the report. Currently, certain exceptions on urllib create conditions where the generated report where a website with a properly generated screenshot is reported as having errored and the screenshot is not included in the report.

Any additional information

some code for this condition already exists on the timeout handling in report generation -- where the report screenshot is included if it exists but urllib failed on timeout. New error handling on urllib calls may cause similar conditions on other errors. the report generation should be updated to always show a report if it exists, even if urllib failed for any reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug python Python codebase
Projects
None yet
Development

No branches or pull requests

1 participant