Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fancier Weather] Rain instead of snow in extreme hills biome #22

Open
1 of 2 tasks
Meldexun opened this issue Mar 6, 2023 · 3 comments
Open
1 of 2 tasks

[Fancier Weather] Rain instead of snow in extreme hills biome #22

Meldexun opened this issue Mar 6, 2023 · 3 comments
Assignees
Labels
Bug Something isn't working as intended Need Investigation

Comments

@Meldexun
Copy link

Meldexun commented Mar 6, 2023

Describe the bug

Tried to do a small test for #21 to make sure everything still works and noticed that it is now raining in the extreme hills biome instead of snowing.

Reproducibility

Please try to reproduce the issue with as few other mods as possible. Then check one of the following checkboxes according to your results. To check a checkbox, replace the space between the square brackets with an x (like this [x]) or create the issue and check the checkbox by clicking on it.

  • I reproduced this issue with as few other mods as possible installed.
  • I am unable to reproduce this issue consistently.

To Reproduce

Steps to reproduce the behavior:

  1. Go to ExtremeHills biome
  2. Run /weather rain
  3. See rain instead of snow

Expected behavior

Snow particles in the extreme hills biome while it is raining.

Screenshots or/and videos

This is the same world and position as the videos from #20.

2023-03-06_14 04 36

Versions

Specification:

  • OS: Windows 10
  • CPU: Ryzen 7 5600
  • GPU: RTX 2070
  • RAM Allocated: 1GB

All of these info below are not necessary but may become necessary depending on the issue

  • CPU Speed: 4.2GHz
  • CPU Core: 6
  • CPU Threads: 12
  • RAM Size: 32GB
  • RAM Speed: 3200MHz
  • Storage Type: SSD
  • GPU VRAM: 8GB
@Desoroxxx
Copy link
Member

Oh no Mojang what have you done...

Does this happen only with that biome?
If you remove FBP do you see snow?

@Desoroxxx Desoroxxx added Need Investigation Bug Something isn't working as intended labels Mar 7, 2023
@Meldexun
Copy link
Author

Meldexun commented Mar 8, 2023

Does this happen only with that biome?

I haven't done a lot of testing but I suspect that the extreme hills biome is only a partial snowy biome and similar biomes will have the same issue.

If you remove FBP do you see snow?

Yes. That's also why there are snow layer blocks on the ground.

@Desoroxxx
Copy link
Member

Weird, FBP checks against the getEnableSnow method from Minecraft, so either this method is broken, or somethings is off
image

@Desoroxxx Desoroxxx changed the title Rain instead of snow in extreme hills biome [Fancier Weather] Rain instead of snow in extreme hills biome Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working as intended Need Investigation
Development

No branches or pull requests

2 participants