Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fancy Block Placement] Ambient Occlusion Missing From Dummy Block & Weird Behaviors #12

Open
Krutoy242 opened this issue Dec 23, 2022 · 18 comments
Assignees
Labels
Bug Something isn't working as intended Goal: 1.0 Hopefully Maybe In The Case Of Potential Luck: 0.8 Need Investigation Project: Pacificus Ponens Revamp of the "Fancy Place Animation" feature which will be renamed "Fancy Block Placement"

Comments

@Krutoy242
Copy link

Describe the bug

Placing blocks causing various rendering glitches, including:

  1. Double of block on same place

For several frames, there is two blocks on same place - one moving and second stand still

  1. Shadow blinking around block

When you place block, shadow appear for split second, then block "falls" without shadow, then shadow appear again when animation ends

  1. Disappearing of block at last moment

Just frame before animation of block placement finished, block disappear, only frame of block visible

Double block and and shadow blink:

KqqZSYUxYW

Transparent block at last moment

javaw_OsVn6u8HlH

Specification:

  • OS: Windows 10
  • CPU: i5-7400 @ 3.00 GHz
  • GPU: GTX 1050 Ti
  • RAM Allocated: 6GB

Additional context

Happen on E2E-E modpack.

@Desoroxxx
Copy link
Member

Thanks for the report!

For the first point I am pretty sure this is fixed in the dev builds of FBP.

For the third, I need to talk with some peoples but I think this cannot be fixed (Actually I may have an idea, note to myself: Look into the materials property for the dummy block)

For the fifth point I never seen that behavior maybe it's also fixed in the dev build.

If you do not mind you could try with a test build and see if the issues are the same, they are posted on my Discord in the dev-builds channel (https://discord.gg/CBpqejmuWx)

I will release an up to date build right now.

@Krutoy242
Copy link
Author

(oh, i just noticed, that when i added sub-descriptions GitHub incrememt numbers 😁)

@Krutoy242
Copy link
Author

If you do not mind you could try with a test build and see if the issues are the same, they are posted on my Discord in the dev-builds channel (discord.gg/CBpqejmuWx)

Ok, i just tested dev build Fancier-Block-Particles-0.8-Dev-9. All three problems still there. Observing no changes.

@Desoroxxx Desoroxxx added Bug Something isn't working as intended Need Investigation labels Dec 25, 2022
@Desoroxxx
Copy link
Member

Just came to mind, are you using Optifine?

@Krutoy242
Copy link
Author

Yes, i do

@Desoroxxx
Copy link
Member

Optifine might be causing this

@Krutoy242
Copy link
Author

Krutoy242 commented Dec 26, 2022

Optifine might be causing this

I removed Optifine and tested again. All three problems still there, nothing fixed.

I used 0.8-Dev-9 version for test.

Update: Tested on 0.8-Dev-10 too. Still issues.

@Desoroxxx
Copy link
Member

I could not reproduce the issue with any optimization mod I am suspecting either mod conflict or nvidia nvidiaing

@Krutoy242
Copy link
Author

Then I could try binary search mod that causing it (duh). This could take week or two.

@Desoroxxx
Copy link
Member

First thing try in an instance with only FBP to see if it's not nvidia nvidiaing

@Krutoy242
Copy link
Author

Just tested, all three problems happen when barely no mods installed (only BoP and RecurrentComplex).

Through, problem with second invisible block not obivious, until i spammed zombies to create FPS lags.

DyVnsIXwBS

@Desoroxxx
Copy link
Member

Yeah, this issue seems like a mix of Nvidia Nvidiaing and just me not being able to go faster than your CPU can go.

And putting the Fancy Block animation on a separate thread is probably impossible without breaking a bunch of mods

@Desoroxxx
Copy link
Member

But I may be able to fix the shadow blinking.

But I am currently waiting Meldexun to make a pr of his big changes, since I don't want to cause more merge conflicts.

@Krutoy242
Copy link
Author

Nvidia Nvidiaing

Is that means, that "double block" and "transparent frame" will be issue for FBP for NVidia cards forever?

Nvidia is kinda popular type of video cards... I'm not sure whether to add this mod to the modpack, if it will glitch on all Nvidia cards 🤕

@Desoroxxx
Copy link
Member

Well you can just turn of fancy block placement but from my understanding I currently cannot do much

@Krutoy242
Copy link
Author

Then, I would appreciate if you not close this issue until its fixed, so I could keep subscribed to see when it fixed and then install on modpack.

P.S. I didnt knew that NVidia actually have more than 75% of market

image

@Desoroxxx
Copy link
Member

Desoroxxx commented Jan 1, 2023

Then, I would appreciate if you not close this issue until its fixed, so I could keep subscribed to see when it fixed and then install on mudpack.

I will keep it open for the ambient occlusion missing problem (.3) but the rest I literally cannot fix at least if it stay untraceable.

@Desoroxxx Desoroxxx changed the title Placing block glitching [Fancy Block Placement] Ambient Occlusion Missing From Dummy Block Jan 1, 2023
@Desoroxxx Desoroxxx added Goal: 1.0 Hopefully Maybe In The Case Of Potential Luck: 0.8 Project: Pacificus Ponens Revamp of the "Fancy Place Animation" feature which will be renamed "Fancy Block Placement" and removed Need Investigation labels Jan 23, 2023
@Desoroxxx Desoroxxx changed the title [Fancy Block Placement] Ambient Occlusion Missing From Dummy Block [Fancy Block Placement] Ambient Occlusion Missing From Dummy Block & Weird Behaviors Jan 23, 2023
@Desoroxxx
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working as intended Goal: 1.0 Hopefully Maybe In The Case Of Potential Luck: 0.8 Need Investigation Project: Pacificus Ponens Revamp of the "Fancy Place Animation" feature which will be renamed "Fancy Block Placement"
Development

No branches or pull requests

2 participants