Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto migration #86

Closed
wants to merge 3 commits into from
Closed

Add auto migration #86

wants to merge 3 commits into from

Conversation

vinit717
Copy link
Member

@vinit717 vinit717 commented May 8, 2024

Issue Ticket Number

Description

In this Pr added a function to apply migration when a server start

Breaking Changes

  • Yes
  • No

If your feature introduces breaking changes or if something is missing, please mention the related issue tickets.

Development Tested?

  • Yes
  • No

Confirm whether the changes have been tested locally during development.

Tested in Staging?

  • Yes
  • No

Indicate whether the changes have been tested in the staging environment for dev to main.

Database Changes

  • Yes
  • No

Indicate whether the changes include modifications to the database.

Screenshots

Attach any relevant screenshots, such as test coverage reports, before and after images, or other visual aids.

Additional Notes

Include any additional notes, considerations, or explanations that might be helpful for reviewers.

@prakashchoudhary07
Copy link
Contributor

So can we let bun handel the migration part related logic, instead of we doing it?

main.go Outdated
@@ -18,6 +18,13 @@ func main() {
os.Exit(1)
}

migrationsDir := "./migrations"
Copy link
Contributor

@prakashchoudhary07 prakashchoudhary07 May 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were going to remove the ./migrations and use cmd/migrations, as we were going to let bun handle it?
For versioning and other feature?

@prakashchoudhary07
Copy link
Contributor

Since this is been done in other PR
Its being handled using bun currently, so will be closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create DB migrations in BUN for creating initial tables
2 participants