Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Stop tests on push #137

Open
RitikJaiswal75 opened this issue Aug 22, 2022 · 5 comments
Open

[RFC] Stop tests on push #137

RitikJaiswal75 opened this issue Aug 22, 2022 · 5 comments
Assignees
Labels

Comments

@RitikJaiswal75
Copy link
Contributor

Issue

  • When a PR is created, the git workflow runs tests on all the pull requests, but once the tests are run on pull requests they run again during push

When was the issue discovered?

  • The issue was discovered on 18th August 2022 during a hangout call while trying to merge PRs.

Files that might be creating this

  • .github/workflows/test.yml

Screenshot of the Problem

image

@pranikz
Copy link

pranikz commented Sep 23, 2022

I can pick this issue .
ETA: 2nd October

@shreya-mishra
Copy link
Collaborator

Will you please mention the ETA too ?

@pranikz
Copy link

pranikz commented Sep 28, 2022

Hello @RitikJaiswal75
I have explored in the repo and found out the CI/ CD operations are happening here on PRs not on push and afaik the issue was It was running on Push too , seems the problem is solved in the case of mobile-app repo, If it is happening here can you just point out where it is happening on push?
image

CC : @shreya-mishra

@RitikJaiswal75
Copy link
Contributor Author

it is still present in codeql.yml
image

@RitikJaiswal75 RitikJaiswal75 changed the title Stop tests on push [RFC] Stop tests on push Oct 14, 2022
@RitikJaiswal75
Copy link
Contributor Author

CodeQl YML runs both on push and pull. Is it necessary and if yes why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants