Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InspireHome #12

Merged
merged 28 commits into from
Jul 24, 2020
Merged

InspireHome #12

merged 28 commits into from
Jul 24, 2020

Conversation

bahaadabbagh
Copy link
Collaborator

image

@bahaadabbagh bahaadabbagh self-assigned this Jul 20, 2020
@louisrli
Copy link
Contributor

  1. don't add ammar as a reviewer
  2. i already see a typo in the screenshot, see if you can spot it

louisrli
louisrli reviewed Jul 20, 2020
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
louisrli
louisrli reviewed Jul 20, 2020
View reviewed changes
src/App.js Outdated Show resolved Hide resolved
@bahaadabbagh bahaadabbagh requested a review from Dara-D July 20, 2020 15:53
@Dara-D
Copy link
Collaborator

Dara-D commented Jul 20, 2020 •
edited
Loading

looks good

@Dara-D Dara-D closed this Jul 20, 2020
@Dara-D Dara-D reopened this Jul 22, 2020
louisrli
louisrli reviewed Jul 22, 2020
View reviewed changes
src/components/inspire/Inspire.jsx Outdated Show resolved Hide resolved
src/components/inspire/Inspire.jsx Outdated Show resolved Hide resolved
src/components/inspire/Inspire.jsx Outdated Show resolved Hide resolved
src/containers/home/home.jsx Outdated Show resolved Hide resolved
@louisrli louisrli requested review from louisrli and Dara-D July 23, 2020 19:39
@bahaadabbagh
Copy link
Collaborator Author

PTAL

@louisrli
Copy link
Contributor

it looks good once tests pass and merge conflicts are fixed, i will approve

@bahaadabbagh
Copy link
Collaborator Author

I have no clue why circleci is failing me here and I can't check details because I don't have access. can you assist?

@louisrli
Copy link
Contributor

hmm.. @Ammar-64 can you give students access to the circleci somehow?

does yarn run test and yarn run fix both do nothing locally?

@bahaadabbagh
Copy link
Collaborator Author

does yarn run test and yarn run fix both do nothing locally?

they just pass at this stage. I really have no idea what it could be

@bahaadabbagh
Copy link
Collaborator Author

PTAL

@louisrli louisrli merged commit ed8405a into dev Jul 24, 2020
@louisrli louisrli deleted the inspire_home branch July 24, 2020 13:09
@bahaadabbagh bahaadabbagh linked an issue Jul 25, 2020 that may be closed by this pull request
inspirePart #3
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louisrli louisrli louisrli approved these changes

@Dara-D Dara-D Awaiting requested review from Dara-D

Assignees

@bahaadabbagh bahaadabbagh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inspirePart
3 participants
@bahaadabbagh @louisrli @Dara-D