Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book 2: listing 27 in book does not match progression #1634

Open
whydoubt opened this issue Sep 1, 2024 · 0 comments
Open

Book 2: listing 27 in book does not match progression #1634

whydoubt opened this issue Sep 1, 2024 · 0 comments
Milestone

Comments

@whydoubt
Copy link
Contributor

whydoubt commented Sep 1, 2024

Listing 26 changed (in main.cc)

auto ground_material = make_shared<lambertian>(color(0.5, 0.5, 0.5));
world.add(make_shared<sphere>(point3(0,-1000,0), 1000, ground_material));

to

auto checker = make_shared<checker_texture>(0.32, color(.2, .3, .1), color(.9, .9, .9));
world.add(make_shared<sphere>(point3(0,-1000,0), 1000, make_shared<lambertian>(checker)));

Listing 27 in the book does not changes these lines.
However, it does include them for context, but it includes the old lines with ground_material.

@hollasch hollasch self-assigned this Nov 12, 2024
@hollasch hollasch added this to the v4.0.2 milestone Nov 12, 2024
@hollasch hollasch removed their assignment Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants