From 5017ac50ec40634e7da444a227cc2e48cf5486ed Mon Sep 17 00:00:00 2001 From: AsadHasan-Rasa Date: Wed, 28 Aug 2024 18:02:22 +0100 Subject: [PATCH 1/2] ENG-1235: Enable triggering release-tagging workflow manually on-demand also, in case previous auto-run(s) had failed --- .github/workflows/tag-release.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/tag-release.yml b/.github/workflows/tag-release.yml index 6b08b577..6a570e7b 100644 --- a/.github/workflows/tag-release.yml +++ b/.github/workflows/tag-release.yml @@ -5,6 +5,7 @@ on: - main - '[0-9]+.[0-9]+.x' types: [closed] + workflow_dispatch: env: COMMIT_EMAIL: sara-tagger@users.noreply.github.com From 37812702b694d3122fcb5cccf6bfd23cbf1dd831 Mon Sep 17 00:00:00 2001 From: AsadHasan-Rasa Date: Thu, 29 Aug 2024 09:33:28 +0100 Subject: [PATCH 2/2] ENG-1235: Addressed PR feedback to update slack notification trigger condition, to not check for tag-build --- .github/workflows/release-artifacts.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release-artifacts.yml b/.github/workflows/release-artifacts.yml index 521d4842..5b44ce0e 100644 --- a/.github/workflows/release-artifacts.yml +++ b/.github/workflows/release-artifacts.yml @@ -146,7 +146,7 @@ jobs: echo "RASA_SDK_VERSION=${RASA_SDK_VERSION/refs\/tags\//}" >> $GITHUB_ENV - name: Notify Slack 💬 - if: env.IS_TAG_BUILD && success() + if: success() env: SLACK_WEBHOOK: ${{ secrets.SLACK_RELEASE_ASSISTANT_RELEASE_WEBHOOK }} uses: Ilshidur/action-slack@2.1.0 @@ -154,7 +154,7 @@ jobs: args: "⚡ New *Rasa SDK* version ${{ env.RASA_SDK_VERSION }} has been released! Changelog: https://github.com/RasaHQ/rasa-sdk/blob/${{ env.RASA_SDK_VERSION }}/CHANGELOG.mdx" - name: Notify Slack of Failure ⛔ - if: env.IS_TAG_BUILD && failure() + if: failure() env: SLACK_WEBHOOK: ${{ secrets.SLACK_RELEASE_ASSISTANT_DEV_TRIBE_WEBHOOK }} uses: Ilshidur/action-slack@2.1.0