forked from ibm-openbmc/pldm
-
Notifications
You must be signed in to change notification settings - Fork 0
/
MAINTAINERS
69 lines (53 loc) · 2.82 KB
/
MAINTAINERS
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
List of maintainers for pldm
===============================
How to use this list:
Find the most specific section entry (described below) that matches where
your change lives and add the reviewers (R) and maintainers (M) as
reviewers. You can use the same method to track down who knows a particular
code base best.
Your change/query may span multiple entries; that is okay.
If you do not find an entry that describes your request at all, someone
forgot to update this list; please at least file an issue or send an email
to a maintainer, but preferably you should just update this document.
Description of section entries:
Section entries are structured according to the following scheme:
X: NAME <EMAIL_USERNAME@DOMAIN> <DISCORD_USERNAME!>
X: ...
.
.
.
Where REPO_NAME is the name of the repository within the OpenBMC GitHub
organization; FILE_PATH is a file path within the repository, possibly with
wildcards; X is a tag of one of the following types:
M: Denotes maintainer; has fields NAME <EMAIL_USERNAME@DOMAIN> <DISCORD_USERNAME!>;
if omitted from an entry, assume one of the maintainers from the
MAINTAINERS entry.
R: Denotes reviewer; has fields NAME <EMAIL_USERNAME@DOMAIN> <DISCORD_USERNAME!>;
these people are to be added as reviewers for a change matching the repo
path.
F: Denotes forked from an external repository; has fields URL.
Line comments are to be denoted "# SOME COMMENT" (typical shell style
comment); it is important to follow the correct syntax and semantics as we
may want to use automated tools with this file in the future.
A change cannot be added to an OpenBMC repository without a MAINTAINER's
approval; thus, a MAINTAINER should always be listed as a reviewer.
Change approval rules:
- Patches must be be approved (+1) by at least 1 maintainer.
- Patches must not have an unresolved -1 vote by any maintainer.
- Patches should have all maintainers added for visibility.
- Patches should include unit tests where possible.
- Feel free to ping on DISCORD about patches that look good but have not
received +2
- Wait 24 hours before doing the final submit after doing a +2 on a
commit and any maintainer can do the final submit
Design approval rules:
- Design discussions should be carried out via email with, at minimum,
all maintainers on the thread. It's encouraged to include the
OpenBMC mailing list in the thread as well.
START OF MAINTAINERS LIST
-------------------------
M: Deepak Kodihalli <[email protected]> <dkodihal!>
M: Tom Joseph <[email protected]> <tomjose!>
M: Sampa Misra <[email protected]> <sampmisr!>
R: George Liu <[email protected]> <George Liu!>
R: Manojkiran Eda <[email protected]> <Manojkiran!>