Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading methods #8

Open
Apostatee opened this issue Jul 15, 2023 · 1 comment
Open

Misleading methods #8

Apostatee opened this issue Jul 15, 2023 · 1 comment

Comments

@Apostatee
Copy link

The repo clearly has major flaws. Predicting returns rather than actual prices is crucial for proper time series forecasting. Otherwise simply using the last observed price as the prediction would be better than the output of your model.
@otoo-peacemaker
Copy link

Alright I'll look into that.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Apostatee @otoo-peacemaker