-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UsartSpi
Support
#562
base: main
Are you sure you want to change the base?
UsartSpi
Support
#562
Conversation
Needs to be tested. Will test via Arudino UNO when I move them ig
…ny SPI modules to test on...
mcu/atmega-hal/src/spi.rs
Outdated
@@ -31,6 +31,66 @@ avr_hal_generic::impl_spi! { | |||
cs: port::PB0, | |||
} | |||
|
|||
#[cfg(any( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Devices where UART port can be a SPI port
Idea, maybe a wild idea: The new code in one Anyway: Success with testing. |
Wait. It actually worked on hardware? Part of me is surprised lol I'll probably move it into its own module, but can't use one config, because they align to different ports between devices. |
Currently added in (I think) at minimum all the USART0 implimentations. But there's still a large portion to go, and finding the XCK pin requires getting the datasheet for each. |
…cludes rejig of pin layouts between boards.
Implements USART, correctly, on all devices. Should past CI successfully. An example could be in order, however, I am lacking any SPI slaves, so I cannot test this myself. |
SPI can be tested very easily by looping back MOSI to MISO (so TX to RX in this case). We also have this in our real SPI example, maybe it makes sense to add an example that does the same for |
… doesn't have the right pins. Will fix that soon. If someone else can test would be great.
Hey, there seem to be some compiler errors, as seen in CI. Can you take a look? |
PR regarding issue #561.
This is just so I have the PR made for now, work still needs to be made on it.
So far,
USART0
is implemented for most of theatmega
mc's. However, they are not tested, as I am lacking something to test it with.