Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hover state of <h3> when no carpool is found #644

Open
dryan opened this issue Aug 28, 2018 · 0 comments
Open

Fix hover state of <h3> when no carpool is found #644

dryan opened this issue Aug 28, 2018 · 0 comments
Labels
starter Good issue to get warmed up on the codebase

Comments

@dryan
Copy link
Contributor

dryan commented Aug 28, 2018

Taking part of #467 and making it it's own issue.

When no results are found for a search, the fallback markup still uses the .result class. This makes the title in that div change color on hover like a link.

Two approaches to fixing this:

  1. Edit https://github.com/RagtagOpen/nomad/blob/master/app/static/js/find.js#L287 so that it doesn't use the .result class and give it a new class that has the same padding as .result.

  2. Change the CSS at https://github.com/RagtagOpen/nomad/blob/master/app/static/css/styles.css#L363 so that the styles that currently apply to <h3>s inside .result apply to <a> tags within those <h3>s instead.

Number two is the better choice in my opinion.

@jillh510 jillh510 added the starter Good issue to get warmed up on the codebase label Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
starter Good issue to get warmed up on the codebase
Projects
None yet
Development

No branches or pull requests

2 participants