Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBtpaint2.c:529 please review of 'break' keyword location #339

Open
dlmiles opened this issue Oct 7, 2024 · 0 comments
Open

DBtpaint2.c:529 please review of 'break' keyword location #339

dlmiles opened this issue Oct 7, 2024 · 0 comments

Comments

@dlmiles
Copy link
Contributor

dlmiles commented Oct 7, 2024

https://github.com/RTimothyEdwards/magic/blob/master/database/DBtpaint2.c#L529

Please review the indentation of this break keyword, as it makes the containing for() loop redundant and reduces it to an if(TT_TECHDEPBASE < DBNumUserLayers) statement.

Maybe a comment left in the area to say this is ok/intentional with some insight might help the next reader.

SonarCloud
Change this loop body so that it can be executed more than once.
https://sonarcloud.io/project/issues?open=AZJB16rNNGfDNup0RiZp&id=dlmiles_magic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant