Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate .amdhsa_reserve_xnack_mask 0 in all assembly kernels. #9

Open
atamazov opened this issue Oct 11, 2020 · 4 comments
Open

Generate .amdhsa_reserve_xnack_mask 0 in all assembly kernels. #9

atamazov opened this issue Oct 11, 2020 · 4 comments
Assignees
@carlushuang
Labels
enhancement New feature or request value_unknown

Comments

@atamazov
Copy link

This will prevent rolling back changes from ROCm/MIOpen#505 when regenerating kernels.

/cc @daniellowell @shurale-nkn
@atamazov atamazov added enhancement New feature or request value_high labels Oct 11, 2020
@atamazov
Copy link
Author

Hmm... Perhaps this is not really required, see https://github.com/ROCmSoftwarePlatform/MIOpen/pull/505/files#r502967373

@carlushuang
Copy link
Collaborator

Hi @atamazov it seems @shurale-nkn added that .amdhsa_reserve_xnack_mask in every asm kernel source code in MIOpen, however it still seems the xnack default value is target-dependent.
Maybe I can add this directive while generate the kernels, but will generate different value of .amdhsa_reserve_xnack_mask based on target features. what do you think?

Ah, -mno-xnack compiler flag is still needed

@atamazov
Copy link
Author

atamazov commented Oct 12, 2020 •
edited
Loading

Most likely, this .amdhsa_reserve_xnack_mask 0 is not required in the generated kernels. The recent target-id related changes in the assembler looks weird. Let's see.

@carlushuang
Copy link
Collaborator

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlushuang carlushuang

Labels
enhancement New feature or request value_unknown
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carlushuang @atamazov