Migrating step of shared folder issues on shared filesystem

[kevinreniers]

Before submitting your issue, please make sure that you've checked all of the checkboxes below.

• You're running the latest release version of Deployer.
• Ensure that you're running at least PHP 7.0.8, you can check this by running php -v
• You've ran composer install --no-dev from the root of your installation.
• You've ran npm install --production from the root of your installation.
• You've ran rm -rf bootstrap/cache/* from the root of your installation.
• You have restarted the queue listener and node socket server.

Describe the bug

When using a shared filesystem between multiple servers during the "Install Composer Dependencies" step, this occurs:

Shared directory needs migrating - Backup created
mv: cannot move '/var/www/redacted/shared' to '/var/www/redacted/shared.backup': Device or resource busy

From what I can tell, this step was added in the 0.0.47 release. Falling back to the 0.0.46 release fixes this issue.

It also increases the runtime of this step from 28 seconds to ~10 minutes or more on some of our servers because it's trying to mv around ~100GB of data in the shared folder.

Expected behaviour

For the tool not to create a shared.backup/ dir.

Actual behaviour

It creates a shared.backup/ dir.

Steps to reproduce

Have a shared filesystem spread over multiple servers. Try to do a deploy.

Screenshots

n/a

Environment info

Laravel Environment

• Laravel Version: 5.4.30
• Timezone: Europe/Brussels
• Debug Mode: ✔
• Storage Dir Writable: ✔
• Cache Dir Writable: ✔
• Decomposer Version: ^1.0
• App Size: 538 MB

Server Environment

• PHP Version: 7.2.14-1+020190205200805.15+stretch1.gbpd83c69
• Server Software: nginx/1.10.3
• Server OS: Linux amphion 4.9.0-4-amd64 Route models #1 SMP Debian 4.9.51-1 (2017-09-28) x86_64
• Database: mysql
• SSL Installed: ✘
• Cache Driver: file
• Session Driver: file
• Openssl Ext: ✔
• PDO Ext: ✔
• Mbstring Ext: ✔
• Tokenizer Ext: ✔
• XML Ext: ✔
• Curl Ext: ✔
• GD Ext: ✔
• JSON Ext: ✔

Installed Packages & their version numbers

• andywer/js-localization : dev-laravel-5
• backup-manager/laravel : ^1.1
• creativeorange/gravatar : ~1.0
• cweagans/composer-patches : dev-master
• doctrine/dbal : ~2.5
• fideloper/proxy : ^3.1
• graham-campbell/binput : ~3.3
• graham-campbell/htmlmin : ~4.2
• guzzlehttp/guzzle : ^6.2
• intervention/image : ^2.3
• laracademy/interactive-make : ^0.5.0
• laravel-notification-channels/hipchat : ~0.2
• laravel-notification-channels/twilio : ~1.0.2
• laravel-notification-channels/webhook : ~1.0.2
• laravel/framework : ^5.4
• laravel/tinker : 1.0.*
• lubusin/laravel-decomposer : ^1.0
• mccool/laravel-auto-presenter : ^5.0
• melihovv/laravel-log-viewer : ^1.2
• michele-angioni/multi-language : 0.3
• pda/pheanstalk : ~3.1
• pragmarx/google2fa : ^1.0.0
• predis/predis : ~1.0
• tymon/jwt-auth : ~0.5
• version/version : ^2.2

Extra Information

• proc_open enabled : ✔

Logs (see storage/logs/) or other output that would be helpful

Shared directory needs migrating - Backup created
mv: cannot move '/var/www/redacted/shared' to '/var/www/redacted/shared.backup': Device or resource busy