There is one more pattern of this in the `static` block at the end of the file; do you want to replace this as well? Might be good then to make `peeked()` package-private to avoid a synthetic accessor method (I assume). #8

OMEEd11990 · 2022-03-11T22:45:59Z

There is one more pattern of this in the static block at the end of the file; do you want to replace this as well? Might be good then to make peeked() package-private to avoid a synthetic accessor method (I assume).
Maybe at that point it might also make sense to merge peeked() and doPeek() into one method?

(I am not a member of this project; the maintainers will probably give you more in-depth feedback)

Originally posted by @Marcono1234 in google/gson#2083 (review)

The text was updated successfully, but these errors were encountered:

OMEEd11990 · 2022-03-11T22:46:53Z

Hi

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

There is one more pattern of this in the `static` block at the end of the file; do you want to replace this as well? Might be good then to make `peeked()` package-private to avoid a synthetic accessor method (I assume). #8

There is one more pattern of this in the `static` block at the end of the file; do you want to replace this as well? Might be good then to make `peeked()` package-private to avoid a synthetic accessor method (I assume). #8

OMEEd11990 commented Mar 11, 2022

OMEEd11990 commented Mar 11, 2022

There is one more pattern of this in the static block at the end of the file; do you want to replace this as well? Might be good then to make peeked() package-private to avoid a synthetic accessor method (I assume). #8

There is one more pattern of this in the static block at the end of the file; do you want to replace this as well? Might be good then to make peeked() package-private to avoid a synthetic accessor method (I assume). #8

Comments

OMEEd11990 commented Mar 11, 2022

OMEEd11990 commented Mar 11, 2022

There is one more pattern of this in the `static` block at the end of the file; do you want to replace this as well? Might be good then to make `peeked()` package-private to avoid a synthetic accessor method (I assume). #8

There is one more pattern of this in the `static` block at the end of the file; do you want to replace this as well? Might be good then to make `peeked()` package-private to avoid a synthetic accessor method (I assume). #8