Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pypy and maybe graalpy support to generate-ci #2013

Open
messense opened this issue Mar 28, 2024 · 3 comments
Open

Add pypy and maybe graalpy support to generate-ci #2013

messense opened this issue Mar 28, 2024 · 3 comments
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code good first issue Good for newcomers

Comments

@messense
Copy link
Member

messense commented Mar 28, 2024

we can add a new cli option --python-implementation to select python impls to build wheels for, it should support these options:

  • cpython (enabled by default)
  • pypy
  • graalpy (if we can upload graalpy wheels to pypi, need to check that)

https://github.com/PyO3/maturin/blob/main/src/ci.rs

@messense messense added enhancement New feature or request good first issue Good for newcomers github_actions Pull requests that update GitHub Actions code labels Mar 28, 2024
@masklinn
Copy link

masklinn commented Aug 4, 2024

graalpy (if we can upload graalpy wheels to pypi, need to check that)

Aren't cffi wheels implementation independent?

So maybe that could just be based on the binding kind?

cpyext don't seem very encouraged 1 2 and e.g. documentation is basically nonexistent (and many old links are dead), it requires linking against pypy's headers and not linking against libpython, which I'm not sure pyo3 / maturin supports (I didn't really find any references to that anywhere), so I figured cffi was the more likely way to support pypy (and graal) if I wanted that.

@messense
Copy link
Member Author

messense commented Aug 5, 2024

@masklinn
Copy link

masklinn commented Aug 5, 2024

@masklinn Both PyPy and GraalPy are supported, see

Thanks for the correction, are there docs around for those? I didn’t find anything when looking around maturin’s docs hence my belief that cffi would be the most well trodden path for pypy and graal (I understand uniffi also works with pypy, I wasn’t clear if it would work with graal at all).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants