Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] findUnspentRecords should not use request failure to check unspent record #829

Open
shresthagrawal opened this issue Dec 25, 2023 · 0 comments
Open

[Bug] findUnspentRecords should not use request failure to check unspent record #829

shresthagrawal opened this issue Dec 25, 2023 · 0 comments
Assignees
@onetrickwolf
Labels
bug Something isn't working

Comments

@shresthagrawal
Copy link

shresthagrawal commented Dec 25, 2023 •
edited
Loading

🐛 Bug Report

findUnspentRecords currently calls the getTransactionId API and, upon failure, assumes that the record is unspent. Using an unspecified catch block to handle core logic is an anti-pattern. The API errors can happen for unknown reasons, which would lead to false positives.
@shresthagrawal shresthagrawal added the bug Something isn't working label Dec 25, 2023
@onetrickwolf onetrickwolf self-assigned this Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onetrickwolf onetrickwolf

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@onetrickwolf @shresthagrawal