Colors don't work in emacs-nox

[cryslith]

This is because proof-general's proof-face-specs function defines its color classes like:

((((type x) (class color) (background light)) (:background "#eaf8ff" :extend t)) (((type x) (class color) (background dark)) (:background "darkslateblue" :extend t)) (((type mswindows) (class color) (background light)) (:background "#eaf8ff" :extend t)) (((type mswindows) (class color) (background dark)) (:background "darkslateblue" :extend t)) (((type w32) (class color) (background light)) (:background "#eaf8ff" :extend t)) (((type w32) (class color) (background dark)) (:background "darkslateblue" :extend t)) (((type gtk) (class color) (background light)) (:background "#eaf8ff" :extend t)) (((type gtk) (class color) (background dark)) (:background "darkslateblue" :extend t)) (((type mac) (class color) (background light)) (:background "#eaf8ff" :extend t)) (((type mac) (class color) (background dark)) (:background "darkslateblue" :extend t)) (((type carbon) (class color) (background light)) (:background "#eaf8ff" :extend t)) (((type carbon) (class color) (background dark)) (:background "darkslateblue" :extend t)) (((type ns) (class color) (background light)) (:background "#eaf8ff" :extend t)) (((type ns) (class color) (background dark)) (:background "darkslateblue" :extend t)) (((type x-toolkit) (class color) (background light)) (:background "#eaf8ff" :extend t)) (((type x-toolkit) (class color) (background dark)) (:background "darkslateblue" :extend t)) (t (:underline t :extend t)))

by enumerating over the list of all possible display types.
This fails to handle terminals even though many terminals support color.
It would be better to drop the type restrictions and define faces based on which graphical features (like color) the display supports.

[monnier]

+1

Patch welcome