Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction log index is incorrect #1

Open
protinam opened this issue Feb 24, 2018 · 0 comments
Open

Transaction log index is incorrect #1

protinam opened this issue Feb 24, 2018 · 0 comments

Comments

@protinam
Copy link
Member

protinam commented Feb 24, 2018

This can lead to duplicate settlement entries where a single order was only settled once but the transaction was mined once, then the chain followed a different fork and the transaction was mined again with a different logIndex. Conceptually, I believe our usage is correct but go-ethereum's implementation is wrong.

See ethereum/go-ethereum#2028

Geth's implementation is unlikely to change, so we will need to implement a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant