Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resource gallery #468

Merged
merged 6 commits into from
Dec 9, 2024
Merged

Update resource gallery #468

merged 6 commits into from
Dec 9, 2024

Conversation

jukent
Copy link
Contributor

@jukent jukent commented Dec 4, 2024

Closes #439

erogluorhan and others added 4 commits January 18, 2024 12:08
Correct the fact that json file data being dumped into yaml file with incorrect format
@jukent jukent requested a review from a team as a code owner December 4, 2024 16:49
@jukent jukent requested review from dopplershift and dcamron and removed request for a team December 4, 2024 16:49
Copy link
Contributor

github-actions bot commented Dec 4, 2024

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: ca79488
✅ Deployment Preview URL: https://projectpythia.github.io/_preview/468

@jukent jukent requested a review from erogluorhan December 4, 2024 17:17
Copy link
Member

@erogluorhan erogluorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was much needed; thanks a lot for doing it!

@jukent jukent merged commit 3729e1a into main Dec 9, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 9, 2024
@jukent
Copy link
Contributor Author

jukent commented Dec 9, 2024

@erogluorhan
Copy link
Member

Seems to still be having issues: https://github.com/ProjectPythia/projectpythia.github.io/actions/runs/12240686083/job/34144102576

It seems to be due to a validation issue this time though (previously validation was passed and PR was created but the PR's changed file was ill-formatted and mistaken content). The validation failure is probably due to a format problem in the issue you created. Please compare with this older issue and try to match its format/content

@jukent
Copy link
Contributor Author

jukent commented Dec 11, 2024

@erogluorhan I actually copied that issue to create the test. But I'm realizing now that I copied the formatted content instead of the raw.

@jukent
Copy link
Contributor Author

jukent commented Dec 11, 2024

Also that old issue is triggering validation errors now (I think because Michaela's affiliation isn't a string). I'm not sure why it is more picky now than it used to be.

It would be nice if there was some sort of comment when validation checks fail.

E: It was actually upset because one author had no affiliation information. Opening a new PR to fix the "open PR" failure in #475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource Gallery submission automation is broken
2 participants