Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Problem with dicom_seg_writer_operator #397

Closed
hossam99-9 opened this issue Nov 16, 2022 · 1 comment · Fixed by #401
Closed

[BUG] Problem with dicom_seg_writer_operator #397

hossam99-9 opened this issue Nov 16, 2022 · 1 comment · Fixed by #401
Labels
bug Something isn't working

Comments

@hossam99-9
Copy link

While trying to use MONAI deploy , while viewing segmentation overlaied over the original scan on OHIF , there was a shift between the segmentation and image .

In 3d slicer I had the same problem but using extension solved the problem.

The seg file has tags that solve the problem but it's not being parsed in OHIF.

the original scan was 204 instance but the segmentation was only 87.

probably the problem is in the ( dicom_seg_writer_operator ) module , the flag (skip empty frames) in highdicom is set to TRUE by default ,

making it optional will fix the issue.

Model used for segmentation ( spleen_ct model ( Model zoo ) )

Thanks in advance.

@hossam99-9 hossam99-9 added the bug Something isn't working label Nov 16, 2022
@MMelQin
Copy link
Collaborator

MMelQin commented Nov 25, 2022

@hossam99-9 Thanks for the report and the workaround. @CPBridge

As you rightfully mentioned, it is the DICOM Seg viewer(s) which is limited and not fully compliant with DICOM standards. The output from DICOM Seg Writer, using highdicom backend, is validated by DICOM validation tools, e.g. David Clunie's validator, and in fact, David is a contributor to highdicom.

For OHIF, there seem be more than this issue, e.g. segments displayed out of position, and an open issue is on its board. as well as this one on MONAI Deploy board.

So, this is not a bug in highdicom or the App SDK Seg Writer. However, we can consider adding the option to alter the omit_empty_frames =True to workaround the issue, and make this as an improvement.

@MMelQin MMelQin linked a pull request Dec 7, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants