Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: issue-590 #634

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Fix: issue-590 #634

merged 1 commit into from
Jun 10, 2024

Conversation

tblivet
Copy link
Contributor

@tblivet tblivet commented Jun 3, 2024

Questions Answers
Description? Fix #590
Type? bug fix / improvement
BC breaks? no
Deprecations?
Fixed ticket? Fix #590
Sponsor company @PrestaShopCorp
How to test? ⬇️

Hi, I propose this fix to address the issue : #590

  • Wording has been updated as follows:
    • "Order as a guest" → when guest order is activated in "Shop parameters" → "Order settings".
    • "New customer" → when guest order is not activated.
  • An improvement has been made: When guest order is activated, we now have a checkbox to show/hide the password field, allowing users to choose whether to create an account or not.

@florine2623 florine2623 self-assigned this Jun 10, 2024
florine2623
florine2623 approved these changes Jun 10, 2024
View reviewed changes
Copy link

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tblivet ,

Worked as expected :

Screen.Recording.2024-06-10.at.16.34.16.mov

Order a guest with/out password ✅
New customer. Customer account is well created with password ✅

@nicosomb nicosomb added this to the v0.2.1 milestone Jun 10, 2024
@nicosomb nicosomb merged commit 251ae15 into PrestaShop:develop Jun 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boherm boherm boherm approved these changes

@florine2623 florine2623 florine2623 approved these changes

@nicosomb nicosomb nicosomb approved these changes

@Hlavtox Hlavtox Awaiting requested review from Hlavtox

@ga-devfront ga-devfront Awaiting requested review from ga-devfront

Assignees

@florine2623 florine2623

Labels
QA ✔️
Projects
PR Dashboard
Archived in project
Milestone
v0.2.1
Development

Successfully merging this pull request may close these issues.

hummingbird - In Checkout process, Personal Information tab, wording in incorrect
5 participants
@tblivet @nicosomb @florine2623 @boherm @ps-jarvis