-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: issue-567 #632
Fix: issue-567 #632
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @tblivet ,
The zoom icon on quick view is not hidden. When I click on it, the page is greyed out :
Screen.Recording.2024-06-05.at.11.46.12.mov
Could you check it please ?
The improvement works as expected ✅
Thanks!
Hello @florine2623, I have just re-tested, and I don't have any problems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @tblivet !
I retested this feature. it works as expected. The right images are displayed according to the combinations. I tested on product details page and quickview page. ✅
But I have noticed another bug that can be fixed in another PR. I do not have the carousel of images displayed.
It should be displayed at the bottom the the main image in product page and quickview.
It should be displayed on the right side when zoomed in.
Before :
before.mov
After :
after.mov