-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deployment to local directory #837
Comments
Can you share the full 1.0 format file (which I would strongly recommend upgrading to 2.0 to see if that fixes your issue)? |
Here's the file. had to rename it to attach it. I can update the file to 2.0 but that doesn't address the question of how I tell the cli which target I want to deploy. |
Table 5.2.6 Setting (There's also undocumented support for If you want to change CLI to be able to deploy locally rather than gh-pages, start looking here I think: https://github.com/PreTeXtBook/pretext-cli/blob/main/pretext/project/__init__.py#L1580 In any case, we need to handle the case where an absolute path is provided to |
OK, after updating to the CLI I don't get the crazy path problem, but it wants to deploy to gh pages, which matches the help string, but is not what I'm after. I want to do a deploy to a local folder, and I would like to be able to specify an absolute path to said folder. |
Yup - that's not a feature today. What might work in the short term is @oscarlevin we might have a use-case for not hard-requiring the stage to live within output here. |
Wait maybe we don't. What if you try |
Maybe we need to make "stage" a first-class verb here. You can "stage" files wherever you want on the local disk, and then you can "deploy" from that stage to GH Pages (and one day we should have support for more kinds of deployments elsewhere on the web). |
|
I think this is a use case where the target should be able to specify an A valid strategy should let you copy the built output to a different folder, as specified by The defaults would still fall back to a github pages deployment to make it easy for beginners that want to start that way. the deploy subcommand would also need to allow for an optional command line parameter that specifies the target. Obviously I could do the copying from my own scripts, but I think it would be nice to make the CLI handle as much of the deployment as possible to keep custom scripts out of it. |
Oops, |
See also discussion at https://groups.google.com/g/pretext-dev/c/FHlYTvMwxMk/ |
@bnmnetp, is this, or some part of this, something you still need? It seems like you have a good plan for Runestone, maybe without this? |
I have implemented the copying in Runestone, but I still think there would be utility in having this feature in the cli. Even for a static build it is nice to be able to:
|
After our discussion on dev I dug into the pretext-cli code. Looking for deploy related code, thinking I could do a PR to make it possible to do a deployment to a given folder.
I found "deploy_dir". So I set it in my project.ptx for the sample-book.
Yes, the sample book still uses the 1.0 format file.
when I tried to run
pretext deploy runestone
. (no dice)Maybe just
pretext deploy
then?I got the following output, actually below is just a fraction of the output.
Seems like deploy could use a
-t
option.The text was updated successfully, but these errors were encountered: