Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interactive previews re-captured on Windows(?) #718

Open
StevenClontz opened this issue Apr 24, 2024 · 2 comments
Open

interactive previews re-captured on Windows(?) #718

StevenClontz opened this issue Apr 24, 2024 · 2 comments

Comments

@StevenClontz
Copy link
Member

Working with https://github.com/tjmagnus/polyomino it was demonsrated that when Terri rebuilds her print target on her own (Windows) machine, the previews for each interactive are being regenerated every time. This is not the intended behavior, where on a Codespace the images are built once then not built again.

@oscarlevin
Copy link
Member

The generate logic is working as intended, but the interactives are not being generated. When I try to generate interactive previews on my windows machine, I get a timeout after 30000ms. Since not all assets were generated, the generate step failed and as such pretext tries to generate them again on the next build.

So, what to do? I'm not sure where the timeout is coming from, perhaps that can be adjusted. Or maybe the right thing to do is to try to save successful assets to the hash table earlier so that we record the ones that work, and on subsequent runs they are not reattempted. It does seem like when it is a subset of assets that need to be generated, that slows things down a LOT: each preview is generated separately, which avoids the timeout, but all the infrastructure for starting the headless browser is done for each xml:id. In fact, in another issue with this, the only reasonable solution I can think of is to not limit by xml:id when multiple assets are requested. Any ideas, @StevenClontz?

@tjmagnus, if you want to get this working while the fix is still in process, you can run pretext generate -q -t print -x ch-intro, which will generate only the previews for the intro chapter (that has xml:id="ch-intro").

@tjmagnus
Copy link

tjmagnus commented May 31, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants