Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project ID's are hard-coded in tests #29

Open
buep opened this issue May 3, 2018 · 0 comments
Open

Project ID's are hard-coded in tests #29

buep opened this issue May 3, 2018 · 0 comments
Milestone

Comments

@buep
Copy link
Contributor

buep commented May 3, 2018

When running tests, using the SD Elements service you supply URL and API token to the tests, pointing it to your service.
The project ID are hard-coded though: https://github.com/Praqma/sdelements-plugin/blob/master/src/test/java/io/jenkins/plugins/sdelements/SDElementsTest.java#L72

They need to be changed for other to run the tests, so they should be extracted out into configuration together with API token and server URL to allow different users to configure their tests.

@buep buep added this to the Backlog milestone May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant