Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty changeset shown on build page #86

Open
RandomSort opened this issue Nov 1, 2017 · 3 comments
Open

Empty changeset shown on build page #86

RandomSort opened this issue Nov 1, 2017 · 3 comments
Milestone

Comments

@RandomSort
Copy link

A trivial PIP freestyle job yields an empty changeset. This has the added issue of not being able to click details and see who made the delivery.

Steps to reproduce:

  • Create empty git repository
  • Put a file in git repository make commit on master branch.
  • Push to remote master
  • Configure a PIP job. No special configuration pickup ready branches, merge to master
  • Allow the job to run its initial build
  • In repository:
    • git checkout -b testbranch
    • echo "changes" > file.txt
    • git add file.txt
    • git commit -m "piptest"
    • git push origin testbranch:ready/testbranch
  • Allow PIP job to run ( or trigger it ).

pip

It will show something like in the picture above. While I would expect something like the picture below.
Note that we are not squashing or changing history in any way. This is a single commit delivery.

image

@buep
Copy link
Contributor

buep commented Nov 1, 2017

Indeed a regression, since the old version of the plugin shows the changes correctly.

For example https://jenkins.praqma.cloud/job/Web_www.praqma.com-integrate/changes

and this http://code.praqma.net/ci/view/Website_Pipelines/view/www.code-conf.com/job/Web_www.code-conf.com-integrate/changes

@RandomSort
Copy link
Author

I'm curious as to what changed this from a bug to enhancement?

@buep
Copy link
Contributor

buep commented Dec 6, 2017

Yes, and I can see I missed to post my explanation.

The reason why we do not see it as a bug is because it have always been there, and worked that way. Many years ago we didn't succeed with the updating the change log, due to technical issues.
I just remembered wrong, it not a regression.

Does it mean it should be fixed? I don't know, as far as a remember it is actually not possible to update the change log from our plugin according to our developer back then.
The reason is that the change log you see on the job page comes from the SCM part of job, and we our plugin takes over control that object is not write-able any more.

We might have new possibilities now that we're technically inside the plugin not a buildwrapper, but a part of the git scm.
I made issues #93 to investigate if that is possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants