Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PiP pipeline Multibranch compliant? #85

Closed
sofusalbertsen opened this issue Nov 1, 2017 · 4 comments
Closed

PiP pipeline Multibranch compliant? #85

sofusalbertsen opened this issue Nov 1, 2017 · 4 comments

Comments

@sofusalbertsen
Copy link

sofusalbertsen commented Nov 1, 2017

After a talk with @groenborg, I seem to get the idea that the new version does not support pipeline multibranch, but only singlebranch pipelines?
More info on the plugin here
https://wiki.jenkins.io/display/JENKINS/Pipeline+Multibranch+Plugin
Can @buep confirm this?

@buep
Copy link
Contributor

buep commented Nov 1, 2017

I can't confirm it because there is not deliberate decision around it. We will support you can use scripted, declarative and job dsl to describe your jobs.
Further that the pretested integration functionality is now there as a git extension instead of a build wrapper.

I don't know what multibranch pipeline requires of special job configurations, but I don't see why it shouldn't work? Any idea what you expect is not working?

Will you try it?

@buep buep modified the milestones: Backlog, Briefings Nov 1, 2017
@buep buep assigned sofusalbertsen and unassigned buep Nov 1, 2017
@MadsNielsen
Copy link
Member

Would be coole if you could try with it @sofusalbertsen

Mulltibranch operates by creating a full pipeline for every branch in your repository, if the repository has a JENKINSFILE you'll get a pipeline in Jenkins (Correct me if im wrong here!).

The JENKINSFILE is interpreted before integration of the ready branch to your integration branch, so if you've done changes in the JENKINSFILE on your ready branch, the pipeline you're execution is not the result of the merge with the integration branch.

So...if your JENKINSFILES are the same it will work as expected...we think :)

@buep
Copy link
Contributor

buep commented Nov 1, 2017

Thanks Mads for that clarification. The problem, which some might see once a while, related to #59.

@sofusalbertsen
Copy link
Author

Closing this one, as I think it actually works.
We do know what integration branch we want to integrate with, and we can find out what branch triggered us, if not anything else, then by the script NT have made.
Could be done more elegant, if the plugin actually did this, but it's not a showstopper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants